Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default for sequential updates #186

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Fix default for sequential updates #186

merged 3 commits into from
Sep 19, 2024

Conversation

dsikka
Copy link
Collaborator

@dsikka dsikka commented Sep 18, 2024

Summary

  • Fix default for sequential updates to be make it True
  • Remove incorrect comment

Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@dsikka dsikka requested a review from Satrat September 18, 2024 19:26
@dsikka dsikka changed the title fix default Fix default for sequential updates Sep 18, 2024
@dsikka dsikka added the ready When a PR is ready for review label Sep 18, 2024
rahul-tuli
rahul-tuli previously approved these changes Sep 18, 2024
Satrat
Satrat previously approved these changes Sep 18, 2024
@kylesayrs kylesayrs dismissed stale reviews from Satrat and rahul-tuli via bb94c70 September 18, 2024 19:50
@dsikka dsikka merged commit 3fb4212 into main Sep 19, 2024
6 of 7 checks passed
@dsikka dsikka deleted the fix_seq_default branch September 19, 2024 00:10
markmc pushed a commit to markmc/llm-compressor that referenced this pull request Nov 13, 2024
Co-authored-by: dhuangnm <dhuang@MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants