Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pytest command to capture results to file #932

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

dbarbuzzi
Copy link
Collaborator

This PR updates the recently added run_tests.sh script to include flags in the pytest command so test results will be captured. It also fixes the improper use of -s as well as makes variable usage consistently safer by wrapping in quotes to prevent unexpected globbing/etc. (now fully passes shellcheck).

@dbarbuzzi dbarbuzzi self-assigned this Nov 25, 2024
Copy link

👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review.

@dbarbuzzi dbarbuzzi added the ready When a PR is ready for review label Nov 25, 2024
Copy link
Collaborator

@dsikka dsikka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this output all the info logs?

@dbarbuzzi
Copy link
Collaborator Author

Will this output all the info logs?

Yes, the tee-sys value for --capture allows pytest to capture all of the output while also mirroring it live to console. If you want live output, this is the value that should be used instead of -s in things like CI/CD.

@dsikka dsikka merged commit 736465c into main Nov 25, 2024
6 of 8 checks passed
@dsikka dsikka deleted the update-run_tests-script branch November 25, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready When a PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants