[Test Fix] Add Quantization then finetune tests #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
|
/ready |
kylesayrs
reviewed
Dec 12, 2024
tests/llmcompressor/transformers/finetune/test_oneshot_then_finetune.py
Outdated
Show resolved
Hide resolved
horheynm
changed the title
kylesayrs
previously approved these changes
Jan 9, 2025
kylesayrs
previously approved these changes
Jan 10, 2025
dsikka
requested changes
Jan 10, 2025
kylesayrs
previously approved these changes
Jan 10, 2025
dsikka
reviewed
Jan 14, 2025
dsikka
previously approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contingent on merge of huggingface/transformers#34719^ has been merged not yet released
SUMMARY:
Add test to
Model must be run_compressed = False to run
Note:
CompressedTensorsConfig. See https://github.com/vllm-project/llm-compressor/pull/964/files#diff-e480ed475c0a5b2beb4052c1dd2aca671999634ace41a5ea017fdff1ce68be0bR130-R135Also fix a bug where in log_sparsification, the layer name is not being recognized so fails. Here nothting is being sparsified, so num params is set to zero
TEST PLAN:
ran the test using transformers main
must pass tests/llmcompressor/transformers/finetune/test_oneshot_then_finetune.py