Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][LoRA]LoRA support added for glm-4v #10418

Merged
merged 4 commits into from
Nov 18, 2024

Conversation

B-201
Copy link
Contributor

@B-201 B-201 commented Nov 18, 2024

To facilitate Lora support, the language model and VL model have been separated. I tested it locally, but it seems I encountered the same issue as this Comment, where the results from vllm differ slightly from those of transformers. However, there is no issue with loading the Lora model, and the results appear to be reasonable.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM, please add related docs!
ping @DarkLight1337 Could you plz look at this PR,thanks

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding support!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 18, 2024 11:19
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 18, 2024
@DarkLight1337 DarkLight1337 merged commit 5be4e52 into vllm-project:main Nov 18, 2024
64 checks passed
@DarkLight1337
Copy link
Member

Oh, I forgot again that we need to update the Supported Models page. Can you open another PR for that? Thanks.

@B-201
Copy link
Contributor Author

B-201 commented Nov 18, 2024

Oh, I forgot again that we need to update the Supported Models page. Can you open another PR for that? Thanks.

Sure, I will open another PR to update the docs.

mikejuliet13 pushed a commit to mikejuliet13/vllm that referenced this pull request Nov 19, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: Manjul Mohan <manjul.mohan@ibm.com>
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: rickyx <rickyx@anyscale.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
prashantgupta24 pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 3, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: B-201 <Joy25810@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants