Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI/Build] Update Dockerfile.rocm #10434

Merged
merged 4 commits into from
Nov 20, 2024
Merged

[CI/Build] Update Dockerfile.rocm #10434

merged 4 commits into from
Nov 20, 2024

Conversation

Alexei-V-Ivanov-AMD
Copy link
Contributor

@Alexei-V-Ivanov-AMD Alexei-V-Ivanov-AMD commented Nov 18, 2024 •
edited by github-actions bot
Loading

Restoring functionality of 'docker build' after pytorch version labels have been pruned.

Signed-off-by: Alexei V. Ivanov alexei.ivanov@amd.com

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 18, 2024
@Alexei-V-Ivanov-AMD
Copy link
Contributor Author

/ready

@Alexei-V-Ivanov-AMD
Update Dockerfile.rocm
020bc92 
Restoring functionality of 'docker build' after pytorch version labels have been pruned.

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 19, 2024 03:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 19, 2024
@DarkLight1337
Copy link
Member

Please merge from main to fix the failing tests.

@Alexei-V-Ivanov-AMD
Merge branch 'vllm-project:main' into patch-3
12b5a42
@Alexei-V-Ivanov-AMD
Update Dockerfile.rocm
bb9c74a 
Pytorch labels keep changing, following up.

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
auto-merge was automatically disabled November 19, 2024 16:29

Head branch was pushed to by a user without write access

@Alexei-V-Ivanov-AMD
Updating the Dockerfile.rocm for the latest set of working PyTorch la…
439985a 
…bels (working as of 20241119 11.25 CT).

Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
@simon-mo simon-mo merged commit d5b68ab into vllm-project:main Nov 20, 2024
67 of 69 checks passed
coolkp pushed a commit to coolkp/vllm that referenced this pull request Nov 20, 2024
@Alexei-V-Ivanov-AMD @coolkp
[CI/Build] Update Dockerfile.rocm (vllm-project#10434)
0643541 
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>

format

Signed-off-by: Kunjan Patel <kunjan@ucla.edu>

Support chat completion

Signed-off-by: Kunjan Patel <kunjan@ucla.edu>

Support chat completion

Signed-off-by: Kunjan Patel <kunjan@ucla.edu>

Support chat completion

Signed-off-by: Kunjan Patel <kunjan@ucla.edu>

Support chat completion + formatting

Signed-off-by: Kunjan Patel <kunjan@ucla.edu>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@Alexei-V-Ivanov-AMD
[CI/Build] Update Dockerfile.rocm (vllm-project#10434)
b961015 
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@Alexei-V-Ivanov-AMD @tlrmchlsmth
[CI/Build] Update Dockerfile.rocm (vllm-project#10434)
9843bb6 
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@Alexei-V-Ivanov-AMD
[CI/Build] Update Dockerfile.rocm (vllm-project#10434)
40824aa 
Signed-off-by: Alexei V. Ivanov <alexei.ivanov@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin mgoin approved these changes

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Alexei-V-Ivanov-AMD @DarkLight1337 @mgoin @simon-mo