-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] gemma2 full context length support #10584
Conversation
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
fixes #9517 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a heads up: the paged attention kernel we use for the xFormers backend doesn't support sliding window attention. This PR will introduce a slight correctness bug in the xformers backend.
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
for xformers, we keep the original behavior of capping the max-model-length. |
This looks great! Which attention backend do you recommend for gemma 2 now? |
@noamgat the default one (flash attention) should work. |
Signed-off-by: youkaichao <youkaichao@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Hi! Thanks for this fix. Can you, please, tell me when the release with this fix is planned? |
Signed-off-by: youkaichao <youkaichao@gmail.com>
For those interested, the release with this fix is version 0.6.5 |
the scheduler treats it as a model without sliding window, and sliding window is only used for computation.
FIX #6220
FIX #8580