Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] gemma2 full context length support #10584

Merged
merged 8 commits into from
Nov 23, 2024

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Nov 22, 2024

the scheduler treats it as a model without sliding window, and sliding window is only used for computation.

FIX #6220
FIX #8580

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@youkaichao
Copy link
Member Author

fixes #9517

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a heads up: the paged attention kernel we use for the xFormers backend doesn't support sliding window attention. This PR will introduce a slight correctness bug in the xformers backend.

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao youkaichao enabled auto-merge (squash) November 23, 2024 01:35
@youkaichao
Copy link
Member Author

Just a heads up: the paged attention kernel we use for the xFormers backend doesn't support sliding window attention. This PR will introduce a slight correctness bug in the xformers backend.

for xformers, we keep the original behavior of capping the max-model-length.

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 23, 2024
@youkaichao youkaichao disabled auto-merge November 23, 2024 04:13
@youkaichao youkaichao merged commit 4aba6e3 into vllm-project:main Nov 23, 2024
63 of 68 checks passed
@youkaichao youkaichao deleted the fix_gemma2 branch November 23, 2024 04:13
@noamgat
Copy link
Contributor

noamgat commented Nov 23, 2024

This looks great! Which attention backend do you recommend for gemma 2 now?

@youkaichao
Copy link
Member Author

@noamgat the default one (flash attention) should work.

mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
@azsh1725
Copy link

azsh1725 commented Dec 9, 2024

Hi! Thanks for this fix.

Can you, please, tell me when the release with this fix is ​​planned?

sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
@azsh1725
Copy link

azsh1725 commented Jan 7, 2025

Hi! Thanks for this fix.

Can you, please, tell me when the release with this fix is ​​planned?

For those interested, the release with this fix is ​​version 0.6.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
4 participants