[Misc] Improve type annotations for support_torch_compile
#10763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
DarkLight1337
added
the
ready
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
afeldman-nm
pushed a commit
to neuralmagic/vllm
that referenced
this pull request
Dec 2, 2024
…ject#10763) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
cedonley
pushed a commit
to cedonley/vllm
that referenced
this pull request
Dec 7, 2024
…ject#10763) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Signed-off-by: cedonley <clayton@donley.io>
sleepwalker2017
pushed a commit
to sleepwalker2017/vllm
that referenced
this pull request
Dec 13, 2024
…ject#10763) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
BKitor
pushed a commit
to BKitor/vllm
that referenced
this pull request
Dec 30, 2024
…ject#10763) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
support_torch_compileerases the information of the original class when the decorated module is used elsewhere. This PR fixes that by providing more precise type annotations to the decorator.