Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Expand OpenAI test_chat.py guided decoding tests #11048

Merged
merged 12 commits into from
Dec 23, 2024
Merged

[CI] Expand OpenAI test_chat.py guided decoding tests #11048

merged 12 commits into from
Dec 23, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Dec 10, 2024 •
edited
Loading

These are easier to enable than test_completions.py, that will come next.

@mgoin
Expand OpenAI guided decoding tests
e155524 
Signed-off-by: mgoin <michael@neuralmagic.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin
Remove comment
ecdb0e2 
Signed-off-by: mgoin <michael@neuralmagic.com>
DarkLight1337
DarkLight1337 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving test coverage!

@mgoin mgoin marked this pull request as draft December 10, 2024 18:05
markmc
markmc reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@markmc markmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, hope the comments help 👍

tests/entrypoints/llm/test_guided_generate.py Outdated Show resolved Hide resolved
vllm/engine/llm_engine.py Outdated Show resolved Hide resolved
@mergify Mergify
Copy link

mergify bot commented Dec 18, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @mgoin.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Dec 18, 2024
@mergify mergify bot removed the needs-rebase label Dec 18, 2024
@mgoin mgoin marked this pull request as ready for review December 19, 2024 01:40
@mgoin mgoin changed the title [CI] Expand OpenAI guided decoding tests [CI] Expand OpenAI test_chat.py guided decoding tests Dec 19, 2024
@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@mgoin mgoin enabled auto-merge (squash) December 23, 2024 17:58
@mgoin mgoin merged commit 63afbe9 into vllm-project:main Dec 23, 2024
47 of 48 checks passed
ayylemao pushed a commit to ayylemao/vllm that referenced this pull request Dec 24, 2024
@mgoin
[CI] Expand OpenAI test_chat.py guided decoding tests (vllm-project#1…
d796455 
…1048)

Signed-off-by: mgoin <michael@neuralmagic.com>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@mgoin @BKitor
[CI] Expand OpenAI test_chat.py guided decoding tests (vllm-project#1…
8cf4404 
…1048)

Signed-off-by: mgoin <michael@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@markmc markmc markmc left review comments

@robertgshaw2-neuralmagic robertgshaw2-neuralmagic Awaiting requested review from robertgshaw2-neuralmagic robertgshaw2-neuralmagic is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

@zhuohan123 zhuohan123 Awaiting requested review from zhuohan123

@youkaichao youkaichao Awaiting requested review from youkaichao

@alexm-neuralmagic alexm-neuralmagic Awaiting requested review from alexm-neuralmagic

@comaniac comaniac Awaiting requested review from comaniac

@njhill njhill Awaiting requested review from njhill

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgoin @markmc @DarkLight1337