Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Adding CPU docker pipeline #11261

Merged
merged 4 commits into from
Dec 19, 2024
Merged

[CI] Adding CPU docker pipeline #11261

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2fad51d
[CI] Adding CPU docker pipeline
zhouyuan Dec 17, 2024
3190285
adding block step for CPU docker build, modify to push to aws registry
zhouyuan Dec 18, 2024
015fab3
Update release-pipeline.yaml
khluu Dec 18, 2024
5294be0
update to use RELEASE_VERSION as docker tag
zhouyuan Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions .buildkite/release-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,3 +55,18 @@ steps:
password-env: DOCKERHUB_TOKEN
env:
DOCKER_BUILDKIT: "1"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a block step here, since it only needs to run on-demand (every release)? The syntax is similar to the Build release image step.

- label: "Build and publish CPU release image"
depends_on: ~
if: build.tag != null
agents:
queue: cpu_queue_postmerge
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khluu not sure if this cpu-queue-postmerge queue is right to build the publish docker image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use this .. but it should push to an ECR instead of Dockerhub. If the cadence is per release version, we can pull the release image manually from ECR then retag and push to Dockerhub cause it's safer that way (putting Dockerhub token on the CI machine has some risk)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouyuan Can you add this command:
aws ecr-public get-login-password --region us-east-1 | docker login --username AWS --password-stdin public.ecr.aws/q9t5s3a7
then we can tag it like public.ecr.aws/q9t5s3a7/vllm-cpu-release-repo:$BUILDKITE_TAG then push

commands:
- "DOCKER_BUILDKIT=1 docker build --build-arg max_jobs=16 --build-arg GIT_REPO_CHECK=1 --tag vllm/vllm-cpu:$BUILDKITE_TAG --progress plain -f Dockerfile.cpu ."
- "docker push vllm/vllm-cpu:$BUILDKITE_TAG"
plugins:
- docker-login#v3.0.0:
username: vllm
password-env: DOCKERHUB_TOKEN
env:
DOCKER_BUILDKIT: "1"
Loading