Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Fix broken phi3-v mm_processor_kwargs tests #11263

Merged
merged 2 commits into from
Dec 18, 2024
Merged

[Bugfix] Fix broken phi3-v mm_processor_kwargs tests #11263

merged 2 commits into from
Dec 18, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Dec 17, 2024 •
edited by github-actions bot
Loading

@Isotr0py
fix broken phi3v mm_processor_kwargs tests
227d890 
Signed-off-by: Isotr0py <2037008807@qq.com>
@Isotr0py
clean up
a59a0f1 
Signed-off-by: Isotr0py <2037008807@qq.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 17, 2024
DarkLight1337
DarkLight1337 approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for breaking this!

@simon-mo simon-mo merged commit 996aa70 into vllm-project:main Dec 18, 2024
64 of 68 checks passed
@Isotr0py Isotr0py deleted the fix-phi3v-mmk branch December 19, 2024 05:39
SageMoore pushed a commit to neuralmagic/vllm that referenced this pull request Dec 19, 2024
@Isotr0py @SageMoore
[Bugfix] Fix broken phi3-v mm_processor_kwargs tests (vllm-project#11263
81db7fc 
)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Sage Moore <sage@neuralmagic.com>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@Isotr0py @BKitor
[Bugfix] Fix broken phi3-v mm_processor_kwargs tests (vllm-project#11263
b746cc7 
)

Signed-off-by: Isotr0py <2037008807@qq.com>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@Isotr0py
[Bugfix] Fix broken phi3-v mm_processor_kwargs tests (vllm-project#11263
cc9ed8e 
)

Signed-off-by: Isotr0py <2037008807@qq.com>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@Isotr0py
[Bugfix] Fix broken phi3-v mm_processor_kwargs tests (vllm-project#11263
f607f48 
)

Signed-off-by: Isotr0py <2037008807@qq.com>
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
@Isotr0py @abmfy
[Bugfix] Fix broken phi3-v mm_processor_kwargs tests (vllm-project#11263
a00d7eb 
)

Signed-off-by: Isotr0py <2037008807@qq.com>
Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
@Isotr0py @abmfy
[Bugfix] Fix broken phi3-v mm_processor_kwargs tests (vllm-project#11263
ce55f19 
)

Signed-off-by: Isotr0py <2037008807@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96 ywang96 is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Isotr0py @DarkLight1337 @simon-mo