Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Add kv cache scales to gemma2.py #11269

Merged
merged 3 commits into from
Dec 23, 2024
Merged

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Dec 17, 2024

Trying to load a gemma2 models with calibrated kv cache scales from llmcompressor/compressed-tensors will fail to load the scales

Tested with:

VLLM_ATTENTION_BACKEND=FLASHINFER vllm serve nm-testing/gemma-2-9b-it-FP8-dynamic-KV --kv-cache-dtype fp8

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin mgoin changed the title Add kv cache scales to gemma2.py [Bugfix] Add kv cache scales to gemma2.py Dec 17, 2024
@mgoin mgoin marked this pull request as draft December 17, 2024 22:24
@mgoin mgoin marked this pull request as ready for review December 18, 2024 17:52
@mgoin mgoin requested a review from DarkLight1337 December 23, 2024 15:18
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 23, 2024 15:38
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 23, 2024
@DarkLight1337 DarkLight1337 merged commit 60fb4f3 into main Dec 23, 2024
68 checks passed
@DarkLight1337 DarkLight1337 deleted the gemma2-kv-cache-scales branch December 23, 2024 19:30
ayylemao pushed a commit to ayylemao/vllm that referenced this pull request Dec 24, 2024
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants