Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix build from source and installation link in README.md #12013

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

Yikun
Copy link
Contributor

@Yikun Yikun commented Jan 13, 2025

This patch:

  • fixes wrong links in readme to avoid the 404.
  • replace vllm.readthedocs.io to docs.vllm.ai to avoid useless rediect.

Related: #11935

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Jan 13, 2025
Signed-off-by: Yikun <yikunkero@gmail.com>
@Yikun Yikun force-pushed the fix-link-in-readme branch from 93f74f3 to a08b238 Compare January 13, 2025 15:47
@Yikun
Copy link
Contributor Author

Yikun commented Jan 13, 2025

cc @DarkLight1337 who involved in #11935

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing the broken links!

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 13, 2025
@mgoin mgoin enabled auto-merge (squash) January 13, 2025 16:26
@mgoin mgoin merged commit 289b519 into vllm-project:main Jan 13, 2025
44 of 46 checks passed
@DarkLight1337
Copy link
Member

Oh, I forgot about those links, thanks for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants