Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc: allow to use proxy in HTTPConnection #12042

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Misc: allow to use proxy in HTTPConnection #12042

merged 1 commit into from
Jan 15, 2025

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Jan 14, 2025 •
edited by github-actions bot
Loading

This patch fixes the HTTPConnection to work with proxy

Ref: https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support

@zhouyuan
Misc: allow to use proxy in HTTPConnection
dad9579 
This patch fixes the HTTPConnection to work with proxy
https://docs.aiohttp.org/en/stable/client_advanced.html#proxy-support

Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

DarkLight1337
DarkLight1337 approved these changes Jan 14, 2025
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. @robertgshaw2-neuralmagic can you confirm?

@zhouyuan
Copy link
Contributor Author

zhouyuan commented Jan 15, 2025 •
edited
Loading

Hi @DarkLight1337 @robertgshaw2-redhat I'm trying on a Qwen-VL example and ran into this issue when downloading a image as my testing env requires http proxy

image

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) January 15, 2025 10:51
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jan 15, 2025
@DarkLight1337
Copy link
Member

Let's merge this first then, perhaps @robertgshaw2-redhat is busy

@DarkLight1337 DarkLight1337 merged commit 5ecf3e0 into vllm-project:main Jan 15, 2025
66 checks passed
ice-tong pushed a commit to ice-tong/vllm that referenced this pull request Jan 18, 2025
@zhouyuan @ice-tong
Misc: allow to use proxy in HTTPConnection (vllm-project#12042)
aaa1fa5 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: ice-tong <xych6@outlook.com>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@zhouyuan
Misc: allow to use proxy in HTTPConnection (vllm-project#12042)
2e75d5a 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
@zhouyuan
Misc: allow to use proxy in HTTPConnection (vllm-project#12042)
057bb17 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
jikunshang pushed a commit to jikunshang/vllm that referenced this pull request Jan 21, 2025
@zhouyuan @jikunshang
Misc: allow to use proxy in HTTPConnection (vllm-project#12042)
6934828 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
@zhouyuan @abmfy
Misc: allow to use proxy in HTTPConnection (vllm-project#12042)
32f2d67 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Signed-off-by: Bowen Wang <abmfy@icloud.com>
abmfy pushed a commit to abmfy/vllm-flashinfer that referenced this pull request Jan 24, 2025
@zhouyuan @abmfy
Misc: allow to use proxy in HTTPConnection (vllm-project#12042)
25915fb 
Signed-off-by: Yuan Zhou <yuan.zhou@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhouyuan @DarkLight1337