-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Neuron][Kernel] Support Longer Sequences in NKI-based Flash PagedAttention and Improve Efficiency #12921
Conversation
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but feel free to chime in.
…ention and Improve Efficiency (vllm-project#12921) Signed-off-by: Lingfan Yu <lingfany@amazon.com> Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
Thanks! |
…ention and Improve Efficiency (vllm-project#12921) Signed-off-by: Lingfan Yu <lingfany@amazon.com>
…ention and Improve Efficiency (vllm-project#12921) Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Summary
This PR is a follow-up of #11277 . It improves code quality and efficiency, and enables kernel to process larger inputs.
Following things are done in this PR:
seqlen_q
(i.e. chunk size in chunked-prefill) is larger than 128 and 512tile_size / block_size <= 128
seqlen_q > 128
,num_blocks_per_tile > 128
)