Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Neuron][Kernel] Support Longer Sequences in NKI-based Flash PagedAttention and Improve Efficiency #12921

Merged
merged 7 commits into from
Feb 12, 2025

Conversation

lingfanyu
Copy link
Contributor

@lingfanyu lingfanyu commented Feb 7, 2025

Summary

This PR is a follow-up of #11277 . It improves code quality and efficiency, and enables kernel to process larger inputs.

Following things are done in this PR:

  • fix 2 tiling issues triggered when seqlen_q (i.e. chunk size in chunked-prefill) is larger than 128 and 512
  • get rid of the limit of how many KV cache block each tile can access, currently tile_size / block_size <= 128
  • unit tests with larger inputs (e.g. seqlen_q > 128, num_blocks_per_tile > 128)
  • skip computation in areas masked out by causal masks
  • load kv cache once for query heads sharing the same kv head
  • remove unused code and format code in pre-commit

Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Copy link

github-actions bot commented Feb 7, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Signed-off-by: Lingfan Yu <lingfany@amazon.com>
@lingfanyu lingfanyu changed the title [Neuron][Kernel] Improve NKI-based flash PagedAttention [Neuron][Kernel] Improve NKI-based Flash PagedAttention Feb 7, 2025
Signed-off-by: Lingfan Yu <lingfany@amazon.com>
@lingfanyu lingfanyu changed the title [Neuron][Kernel] Improve NKI-based Flash PagedAttention [Neuron][Kernel] Support Longer Sequences in NKI-based Flash PagedAttention and Improve Efficiency Feb 7, 2025
@lingfanyu lingfanyu marked this pull request as ready for review February 7, 2025 23:24
Copy link
Contributor

@liangfu liangfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but feel free to chime in.

@simon-mo simon-mo merged commit e92694b into vllm-project:main Feb 12, 2025
17 of 19 checks passed
SzymonOzog pushed a commit to SzymonOzog/vllm that referenced this pull request Feb 12, 2025
…ention and Improve Efficiency (vllm-project#12921)

Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
@lingfanyu
Copy link
Contributor Author

Thanks!

@lingfanyu lingfanyu deleted the nki_pa_improve branch February 12, 2025 18:50
panf2333 pushed a commit to yottalabsai/vllm that referenced this pull request Feb 18, 2025
…ention and Improve Efficiency (vllm-project#12921)

Signed-off-by: Lingfan Yu <lingfany@amazon.com>
kerthcet pushed a commit to kerthcet/vllm that referenced this pull request Feb 21, 2025
…ention and Improve Efficiency (vllm-project#12921)

Signed-off-by: Lingfan Yu <lingfany@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants