-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Guided decoding falls back to outlines when fails to import xgrammar #12976
Conversation
…xgrammar Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
This is easier to review when hiding the whitespaces: https://github.com/vllm-project/vllm/pull/12976/files?diff=unified&w=1 |
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor style feedback. thanks for the fix!
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks!
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Ci failures seem unrelated: @mgoin Would you like to merge this manually? |
…xgrammar (vllm-project#12976) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com> Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
…xgrammar (vllm-project#12976) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…xgrammar (vllm-project#12976) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
…xgrammar (vllm-project#12976) Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
This fixes the issue when xgrammar module cannot be imported successfully for some reason, e.g. triton is not available. This fallback allows users to still use guided decoding when xgrammar cannot be used.