Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Do not use resource module on Windows (#12858) #13029

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

MoonRide303
Copy link
Contributor

@MoonRide303 MoonRide303 commented Feb 10, 2025

Python resource module is supported only on *nix OSes - it should never be imported on Windows.

FIX #12858

Signed-off-by: MoonRide303 <moonride303@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgoin mgoin added the ready ONLY add when PR is ready to merge/full CI is needed label Feb 10, 2025
@mgoin
Copy link
Member

mgoin commented Feb 10, 2025

I'm curious - have you actually tried to get vllm to run on windows? I have only used it on WSL

@MoonRide303
Copy link
Contributor Author

I'm curious - have you actually tried to get vllm to run on windows? I have only used it on WSL

Yup - other apps work just fine, so I see no real reason why vLLM shouldn't :). This was just first obstacle and not the only problem, though - but one thing at a time.

As of WSL - it's fine for running some *nix-only tools, but it's not really that good for more demanding apps. CUDA via WSL worked much worse for me than running it natively on Windows.

@simon-mo simon-mo merged commit 21f5d50 into vllm-project:main Feb 11, 2025
45 of 47 checks passed
SzymonOzog pushed a commit to SzymonOzog/vllm that referenced this pull request Feb 12, 2025
@MoonRide303 MoonRide303 deleted the fix-resource branch February 13, 2025 13:50
@levitation
Copy link

Regarding the motivation why resource module was originally imported - you can use memory limits under Windows as well, but you need a separate implementation for that. One implementation example is available here:
https://github.com/levitation-opensource/python_memory_limit/blob/main/windows_jobobject.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No module named 'resource'
4 participants