-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Do not use resource module on Windows (#12858) #13029
Conversation
Signed-off-by: MoonRide303 <moonride303@gmail.com>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, FYI @robertgshaw2-redhat
I'm curious - have you actually tried to get vllm to run on windows? I have only used it on WSL |
Yup - other apps work just fine, so I see no real reason why vLLM shouldn't :). This was just first obstacle and not the only problem, though - but one thing at a time. As of WSL - it's fine for running some *nix-only tools, but it's not really that good for more demanding apps. CUDA via WSL worked much worse for me than running it natively on Windows. |
…llm-project#13029) Signed-off-by: SzymonOzog <szymon.ozog@aleph-alpha.com>
Regarding the motivation why resource module was originally imported - you can use memory limits under Windows as well, but you need a separate implementation for that. One implementation example is available here: |
Python resource module is supported only on *nix OSes - it should never be imported on Windows.
FIX #12858