[core] SequenceController in SamplingParams #4775
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early work in progress.
This introduces a
controller: SequenceController
field inSamplingParams
. This can be thought of as an extension of the already existinglogits_processors
(and in fact will work together with it).The idea is to allow computation of logit token masks in the background, while the GPU is busy with the forward step, as well as token healing, accelerated decoding (aka fast-forward or zero entropy tokens), and hidden tokens (typically stop tokens). This is essentially what's needed for running Guidance stateless grammars on the server.
@simon-mo please let me know if this looks like it's on the right track!
Fast-forward tokens
The fast-forward tokens are handled naturally with BlockManagerV2 since they are used in prefix caching and chunked prefill. They can greatly speed generation of certain data formats (eg., JSON constrained by a schema).
Backtracking
Large parts of this PR deal with backtracking, that is removing a bunch of recently generated tokens.
It is used by token healing in Guidance - the constraints sometimes make the model output tokens in un-natural way. Guidance periodically re-tokenizes the output (bytes) so far with canonical tokenizer. In some cases this requires removing a bunch of tokens from the output and re-inserting new (byte-equivalent) tokens.
Another motivation for this is stop tokens in Guidance - for example
f'Here's a joke: {gen(stop="\n")}; Score: {gen(regex=r"\d")}'
- here the LLM generates a joke"Something funny\n"
and stops at a newline, however when generating score it should see"Here's a joke: Something funny; Score: "
.Certain implementations of token healing also require it (though not the current one in Guidance).(edited text above - Guidance actually uses this)Another motivation is when you want the LLM to do several independent, related tasks - after the context prompt, you ask for the first task, generate answer, backtrack away the answer and first task question, and continue. This is sometimes also used for XPIA mitigations, where you want to hide untrusted input when generating certain tokens.
Current implementation also uses backtrack when the controller requests a "no-op" (i.e., a backtrack of 0 with empty tokens to append) - this typically means that the controller run out of time computing token masks and wants to sit out a step (this shouldn't happen very often, but would otherwise block other sequences).
The reason backtracking is not a separate PR is that the SequenceController will allow for unit tests for it.
AICI and Guidance
AICI (minus forks) can be implemented on top of this, so this supersedes #2888. There's an ongoing work on Guidance Controller in AICI.
BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Frontend]
For changes on the vLLM frontend (e.g., OpenAI API server,LLM
class, etc.)[Kernel]
for changes affecting CUDA kernels or other compute kernels.[Core]
for changes in the core vLLM logic (e.g.,LLMEngine
,AsyncLLMEngine
,Scheduler
, etc.)[Hardware][Vendor]
for hardware-specific changes. Vendor name should appear in the prefix (e.g.,[Hardware][AMD]
).[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
format.sh
to format your code.docs/source/
if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
action-required
label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!