-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of lacked ignored_seq_groups in _schedule_chunked_prefill #5296
Merged
DarkLight1337
merged 3 commits into
vllm-project:main
from
JamesLim-sy:addition_of_lack_ignored_seq_groups
Jun 7, 2024
Merged
Addition of lacked ignored_seq_groups in _schedule_chunked_prefill #5296
DarkLight1337
merged 3 commits into
vllm-project:main
from
JamesLim-sy:addition_of_lack_ignored_seq_groups
Jun 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamesLim-sy
changed the title
Addition of lack ignored_seq_groups in _schedule_chunked_prefill
Addition of lacked ignored_seq_groups in _schedule_chunked_prefill
Jun 5, 2024
rkooo567
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
can you fix the lint? |
okay! |
also can you merge the latest master? test failure may be fixec by that |
…tion_of_lack_ignored_seq_groups
dtrifiro
pushed a commit
to opendatahub-io/vllm
that referenced
this pull request
Jun 10, 2024
robertgshaw2-redhat
pushed a commit
to neuralmagic/nm-vllm
that referenced
this pull request
Jun 11, 2024
joerunde
pushed a commit
to joerunde/vllm
that referenced
this pull request
Jun 17, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jun 27, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 8, 2024
xjpang
pushed a commit
to xjpang/vllm
that referenced
this pull request
Jul 24, 2024
Temirulan
pushed a commit
to Temirulan/vllm-whisper
that referenced
this pull request
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think
infeasible_seq_groups
generated by_schedule_swapped
should be added intoignored_seq_groups
ofSchedulerOutputs