Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of lacked ignored_seq_groups in _schedule_chunked_prefill #5296

Conversation

JamesLim-sy
Copy link
Contributor

I think infeasible_seq_groups generated by _schedule_swapped should be added into ignored_seq_groups of SchedulerOutputs

@simon-mo simon-mo requested a review from rkooo567 June 5, 2024 22:20
@JamesLim-sy JamesLim-sy changed the title Addition of lack ignored_seq_groups in _schedule_chunked_prefill Addition of lacked ignored_seq_groups in _schedule_chunked_prefill Jun 5, 2024
Copy link
Collaborator

@rkooo567 rkooo567 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@rkooo567
Copy link
Collaborator

rkooo567 commented Jun 6, 2024

can you fix the lint?

@JamesLim-sy
Copy link
Contributor Author

can you fix the lint?

okay!

@JamesLim-sy JamesLim-sy requested a review from rkooo567 June 7, 2024 01:38
@rkooo567
Copy link
Collaborator

rkooo567 commented Jun 7, 2024

also can you merge the latest master? test failure may be fixec by that

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) June 7, 2024 08:28
@DarkLight1337 DarkLight1337 merged commit dc49fb8 into vllm-project:main Jun 7, 2024
103 checks passed
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants