Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Add ignored layers for fp8 quantization #6657

Merged
merged 3 commits into from
Jul 23, 2024

Conversation

mgoin
Copy link
Collaborator

@mgoin mgoin commented Jul 22, 2024

FIX #6592

Allows for ignored layers in fp8.py, like already implemented for compressed-tensors and fbgemm_fp8.
Implements the requested refactor in the above PR:

We should not make this type of logic in llama.py because it will be too difficult to maintain
Instead, let's have Fp8Config.get_quant_method(layer) extend to have the layer_name passed. Then, if the layer_name is in the ignored list we can return UnquantizedLinearMethod() from this function

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mgoin
Copy link
Collaborator Author

mgoin commented Jul 22, 2024

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 22, 2024
@robertgshaw2-neuralmagic robertgshaw2-neuralmagic merged commit 0eb0757 into main Jul 23, 2024
72 checks passed
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Jul 24, 2024
cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Signed-off-by: Alvant <alvasian@yandex.ru>
@simon-mo simon-mo deleted the autofp8-ignored-layers branch October 28, 2024 16:49
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants