-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend] split run_server into build_server and run_server #6740
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
CI failures look unrelated? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup!
…oject#6740) Signed-off-by: Alvant <alvasian@yandex.ru>
This aims to split
run_server
into two: one part responsible for building theuvicorn.Server
and another responsible for running it.With this:
run_server()
is now a coroutine, which can be run usingasyncio.run()
or just awaited when running in an async contextbuild_server()
can now take optional kwargs, which are passed to uvicorn and allow for further customization of the server