Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] split run_server into build_server and run_server #6740

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

dtrifiro
Copy link
Contributor

This aims to split run_server into two: one part responsible for building the uvicorn.Server and another responsible for running it.

With this:

  • run_server() is now a coroutine, which can be run using asyncio.run() or just awaited when running in an async context
  • build_server() can now take optional kwargs, which are passed to uvicorn and allow for further customization of the server

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@dtrifiro dtrifiro marked this pull request as ready for review July 24, 2024 13:40
@dtrifiro
Copy link
Contributor Author

CI failures look unrelated?

@simon-mo simon-mo enabled auto-merge (squash) July 24, 2024 15:54
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Jul 24, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@simon-mo simon-mo disabled auto-merge July 24, 2024 17:36
@simon-mo simon-mo merged commit ee81258 into vllm-project:main Jul 24, 2024
84 of 86 checks passed
@dtrifiro dtrifiro deleted the entrypoint-split-server branch July 25, 2024 08:15
cduk pushed a commit to cduk/vllm-pascal that referenced this pull request Aug 6, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants