-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up remaining Punica C information #7027
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks reasonable to me. Let me take a look myself in the codebase
I recently comment out the LoRA test to save CI cost. Please run those locally and report back. 🙇♂️ |
You can also uncomment them in .buildkite/test-pipeline.yaml and run it in CI |
@simon-mo I will considering optimizing the LoRA-related unit tests . Additionally, regarding this PR, what test content should I provide feedback on? |
vllm/.buildkite/test-pipeline.yaml Lines 204 to 217 in c8a7e93
For this PR to merge, please uncomment these and let it pass in CI first. We are working on optimizing the steps overall. Optimizing the LoRA test is definitely welcomed! |
@simon-mo The LoRA tests have all passed. It seems that a force merge may be necessary. Furthermore, I've noticed that the test for each LoRA slice takes approximately 20 minutes. If we were to optimize the LoRA testing process, should we focus on reducing this time consumption or on improving the resource efficiency within the LoRA tests? |
Great. Can you comment it out for now so it doesn't trigger every commit. And we can force merge |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Let's merge this PR? @jeejeelee @simon-mo
Agreed, I think this PR's task is complete, and all related tests have passed |
Signed-off-by: Alvant <alvasian@yandex.ru>
#5036 has been merged. Cleaning up the remaining Punica C information.
@mgoin I see that most of these formatting-related files were contributed by you. Could you please take a look at this PR? Thanks~