Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LoRA] Relax LoRA condition #7146

Merged
merged 5 commits into from
Aug 6, 2024
Merged

[LoRA] Relax LoRA condition #7146

merged 5 commits into from
Aug 6, 2024

Conversation

jeejeelee
Copy link
Collaborator

@jeejeelee jeejeelee commented Aug 5, 2024 •
edited
Loading

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@jeejeelee
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 5, 2024
DarkLight1337
DarkLight1337 reviewed Aug 5, 2024
View reviewed changes
vllm/lora/layers.py Outdated Show resolved Hide resolved
@jeejeelee
Copy link
Collaborator Author

All LoRA tests have passed

@DarkLight1337 DarkLight1337 requested a review from Yard1 August 5, 2024 13:27
@Yard1 Yard1 enabled auto-merge (squash) August 5, 2024 18:36
@Yard1 Yard1 merged commit 9118217 into vllm-project:main Aug 6, 2024
51 of 52 checks passed
sfc-gh-mkeralapura pushed a commit to sfc-gh-mkeralapura/vllm that referenced this pull request Aug 12, 2024
@jeejeelee @sfc-gh-mkeralapura
[LoRA] Relax LoRA condition (vllm-project#7146)
8f7a457
kylesayrs pushed a commit to neuralmagic/vllm that referenced this pull request Aug 17, 2024
@jeejeelee @kylesayrs
[LoRA] Relax LoRA condition (vllm-project#7146)
0b2266b
@jeejeelee jeejeelee mentioned this pull request Aug 20, 2024
Merged
3 tasks
fialhocoelho pushed a commit to opendatahub-io/vllm that referenced this pull request Aug 22, 2024
@jeejeelee @fialhocoelho
[LoRA] Relax LoRA condition (vllm-project#7146)
b160196
@dreamiter dreamiter mentioned this pull request Sep 16, 2024
Open
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@jeejeelee @Alvant
[LoRA] Relax LoRA condition (vllm-project#7146)
b82e6a3 
Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@jeejeelee
[LoRA] Relax LoRA condition (vllm-project#7146)
25e8577
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 left review comments

@Yard1 Yard1 Yard1 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeejeelee @Yard1 @DarkLight1337