Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model][VLM] Support multi-images inputs for Phi-3-vision models #7783

Merged
merged 17 commits into from
Aug 25, 2024

Conversation

Isotr0py
Copy link
Collaborator

@Isotr0py Isotr0py commented Aug 22, 2024

FILL IN THE PR DESCRIPTION HERE

FIX #5820 FIX #7740 (link existing issues this PR will resolve)

  • This PR adds multi-images inputs support for Phi-3-vision models

TODO

  • Add multi-images inputs support for Phi-3-vision models
  • Add test for multi-images inputs.

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Isotr0py Isotr0py marked this pull request as ready for review August 23, 2024 06:22
@Isotr0py
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 23, 2024
@ywang96
Copy link
Member

ywang96 commented Aug 23, 2024

@Isotr0py From a glance this PR is only for offline inference. Do you plan to make another PR to support multi-image inputs for phi3-V work with online inference? (If not I can do it)

@Isotr0py
Copy link
Collaborator Author

OK, I will make another PR for online inference later.

@pseudotensor
Copy link

@Isotr0py From a glance this PR is only for offline inference. Do you plan to make another PR to support multi-image inputs for phi3-V work with online inference? (If not I can do it)

Naive question, what is meant by online vs. offline inference here?

@ywang96
Copy link
Member

ywang96 commented Aug 23, 2024

@Isotr0py From a glance this PR is only for offline inference. Do you plan to make another PR to support multi-image inputs for phi3-V work with online inference? (If not I can do it)

Naive question, what is meant by online vs. offline inference here?

@pseudotensor
Online inference: you use the model via the API server.
Offline inference: you use the model via the LLM class.

@pseudotensor
Copy link

@Isotr0py From a glance this PR is only for offline inference. Do you plan to make another PR to support multi-image inputs for phi3-V work with online inference? (If not I can do it)

Naive question, what is meant by online vs. offline inference here?

@pseudotensor Online inference: you use the model via the API server. Offline inference: you use the model via the LLM class.

Thanks. Ya I guess many use online as well, I use it 100%, but I know some that use offline.

@zifeitong
Copy link
Contributor

zifeitong commented Aug 23, 2024

OK, I will make another PR for online inference later.

Looking forward to it! I assume it would be a general change to enable OpenAI API for all the models support multi-images?

Edit: I believe #7826 implemented it already.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! See if the tests pass

@DarkLight1337
Copy link
Member

Can you merge from main to fix some of the CI errors?

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) August 25, 2024 10:51
@DarkLight1337 DarkLight1337 merged commit 8aaf3d5 into vllm-project:main Aug 25, 2024
44 checks passed
@Isotr0py Isotr0py deleted the phi3v-multi-images branch August 25, 2024 12:07
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
5 participants