-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci][test] exclude model download time in server start time #7834
[ci][test] exclude model download time in server start time #7834
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
We should have ran |
if not model.startswith("/"): | ||
# download the model if it's not a local path | ||
# to exclude the model download time from the server start time | ||
model = snapshot_download(model) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
snapshot_download can download many more files than we need for inference, such as duplicate .pt files when we prefer to use safetensors. We should try to use a common function with how vLLM usually pulls down files for models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you come up with a fix for it?
I don't know if safetensors would be enough. but we can have atry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically I am proposing using DefaultModelLoader._prepare_weights
def _prepare_weights(self, model_name_or_path: str, |
I can make a PR for this later today
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please go ahead, I do see more files are downloaded in https://buildkite.com/vllm/fastcheck/builds/3094#01918525-98da-4596-8d31-f4e2c1172455
…ject#7834) Signed-off-by: Alvant <alvasian@yandex.ru>
fixes errors observed in https://buildkite.com/vllm/fastcheck/builds/3075#019182d5-5e41-408c-89e8-1d6bb86cc729