-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Async_output_proc: Add virtual engine support (towards pipeline parallel) #7911
[Core] Async_output_proc: Add virtual engine support (towards pipeline parallel) #7911
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge). To run full CI, you can do one of these:
🚀 |
/ready |
a1986d1
to
9e8f61e
Compare
vllm/sequence.py
Outdated
# Async callback | ||
async_callback: Optional[AsyncCallbackData] = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this name is a bit generic? Maybe something like request_output_callback
is better? i.e. to make it clearer what this is calling you back for/with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to have it async_callback because it is not only output_proc anymore in the async + multi-step PR. The callback starts to get more and more functionality inside.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Leave to @njhill
@alexm-neuralmagic Can you please address @njhill's comments? |
Addressed comments, @njhill thanks for the good suggestion with partial funcs! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alexm-neuralmagic
…e parallel) (vllm-project#7911) Signed-off-by: Alvant <alvasian@yandex.ru>
This a small PR that adds virtual engine support to the asynchronous post-processor, which is necessary to allow pipeline parallel.