Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Async_output_proc: Add virtual engine support (towards pipeline parallel) #7911

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

alexm-neuralmagic
Copy link
Collaborator

This a small PR that adds virtual engine support to the asynchronous post-processor, which is necessary to allow pipeline parallel.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which consists a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of default ones by unblocking the steps in your fast-check build on Buildkite UI.

Once the PR is approved and ready to go, please make sure to run full CI as it is required to merge (or just use auto-merge).

To run full CI, you can do one of these:

  • Comment /ready on the PR
  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-neuralmagic
Copy link
Collaborator Author

/ready

@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Aug 27, 2024
@alexm-neuralmagic
Copy link
Collaborator Author

vllm/engine/llm_engine.py Show resolved Hide resolved
vllm/engine/llm_engine.py Show resolved Hide resolved
vllm/sequence.py Outdated Show resolved Hide resolved
vllm/sequence.py Outdated
Comment on lines 1302 to 1303
# Async callback
async_callback: Optional[AsyncCallbackData] = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this name is a bit generic? Maybe something like request_output_callback is better? i.e. to make it clearer what this is calling you back for/with

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer to have it async_callback because it is not only output_proc anymore in the async + multi-step PR. The callback starts to get more and more functionality inside.

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leave to @njhill

@WoosukKwon
Copy link
Collaborator

@alexm-neuralmagic Can you please address @njhill's comments?

@alexm-neuralmagic
Copy link
Collaborator Author

Addressed comments, @njhill thanks for the good suggestion with partial funcs!

Copy link
Member

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WoosukKwon WoosukKwon merged commit f508e03 into vllm-project:main Aug 28, 2024
16 of 19 checks passed
kushanam pushed a commit to kushanam/vllm that referenced this pull request Aug 28, 2024
hbikki pushed a commit to hbikki/vllm that referenced this pull request Aug 28, 2024
kushanam pushed a commit to kushanam/vllm that referenced this pull request Aug 28, 2024
triple-Mu pushed a commit to triple-Mu/vllm_official that referenced this pull request Sep 4, 2024
Jeffwan pushed a commit to aibrix/vllm that referenced this pull request Sep 19, 2024
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
…e parallel) (vllm-project#7911)

Signed-off-by: Alvant <alvasian@yandex.ru>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants