Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]disable cuda graph when max_decode_seq_len is close to max_seq_len_to_capture #8145

Closed
wants to merge 1 commit into from

Conversation

Ximingwang-09
Copy link

when enable spec decoding(num_lookahead_slots = 7)and cuda graph. We meet the problem:ValueError: could not broadcast input array from shape (513,) into shape (512,)
When starting spec decode, in order to ensure sufficient space is allocated, new tokens + num_lookahead_slots slots are allocated by default. Therefore, when the input + output is 8186, 8186 + 7 just triggers the boundary of 8192, requiring an additional block to be allocated, resulting in the block_table length exceeding the input_block_tables[i] range.

Copy link

github-actions bot commented Sep 4, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Ximingwang-09 Ximingwang-09 changed the title [Bugfix]disable cuda graph when max_decode_seq_len is clone to max_seq_len_to_capture [Bugfix]disable cuda graph when max_decode_seq_len is close to max_seq_len_to_capture Sep 4, 2024
@Ximingwang-09
Copy link
Author

related issue:#5563

@youkaichao
Copy link
Member

thanks for the great pr! I think lookahead slots should be the root cause.

however, instead of disabling cudagraph, I think we can actually use cudagraph in this case. we just need to remove the lookahead slots when we copy the block table.

@youkaichao
Copy link
Member

close in favor of #8340

@youkaichao youkaichao closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants