Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Collect model support info in a single process per model #9233

Merged
merged 6 commits into from
Oct 11, 2024

Conversation

DarkLight1337
Copy link
Member

Follow-up to #9208

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 10, 2024
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youkaichao
Copy link
Member

please fix the error. it looks oot registered models are not processed correctly.

@DarkLight1337
Copy link
Member Author

It looks like changes to the registry (via register_model) aren't being preserved in other processes. Is there a good way to solve this?

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Oct 11, 2024

I'm thinking of loading the plugins for each process.

@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Oct 11, 2024

I have fixed this by adding the load_general_plugins call to MQLLMEngine.from_engine_args as well.

@youkaichao
Copy link
Member

It looks like changes to the registry (via register_model) aren't being preserved in other processes. Is there a good way to solve this?

good point. the new process does not load plugins. maybe we can just add one line of loading plugin in the if __name__ == "__main__":

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) October 11, 2024 06:40
@DarkLight1337 DarkLight1337 merged commit e808156 into main Oct 11, 2024
58 checks passed
@tlrmchlsmth
Copy link
Collaborator

Really timely PR, as I was about to make this worse in #6484 😀

tlrmchlsmth added a commit to neuralmagic/nm-vllm that referenced this pull request Oct 11, 2024
@DarkLight1337 DarkLight1337 deleted the inspect-model branch October 11, 2024 13:42
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
…-project#9233)

Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants