-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Collect model support info in a single process per model #9233
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
please fix the error. it looks oot registered models are not processed correctly. |
It looks like changes to the registry (via |
I'm thinking of loading the plugins for each process. |
I have fixed this by adding the |
good point. the new process does not load plugins. maybe we can just add one line of loading plugin in the |
Really timely PR, as I was about to make this worse in #6484 😀 |
…-project#9233) Signed-off-by: Alvant <alvasian@yandex.ru>
…-project#9233) Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
…-project#9233) Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
…-project#9233) Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Follow-up to #9208