Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix][Misc]: fix graph capture for decoder #9549

Merged
merged 1 commit into from
Oct 21, 2024
Merged

[Bugfix][Misc]: fix graph capture for decoder #9549

merged 1 commit into from
Oct 21, 2024

Conversation

yudian0504
Copy link
Contributor

@yudian0504 yudian0504 commented Oct 21, 2024 •
edited
Loading

This PR fixes a bug introduced by #8645.

related issues: #9448 & #9417 & #9409

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@yudian0504 yudian0504 changed the title [Bugfix][Msic]: fix graph capture for decoder [Bugfix][Misc]: fix graph capture for decoder Oct 21, 2024
comaniac
comaniac approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the unblock. Meanwhile, I'm not sure how encoder-decoder works in this case. @varun-sundar-rabindranath PTAL. Also cc @sroy745

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 21, 2024
varun-sundar-rabindranath
varun-sundar-rabindranath approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@varun-sundar-rabindranath varun-sundar-rabindranath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mistake !! Thanks for the fix @yudian0504 🙌

@comaniac comaniac enabled auto-merge (squash) October 21, 2024 16:18
@jeejeelee
Copy link
Collaborator

Good catch, this solved a bug I encountered.

@comaniac comaniac merged commit 8ca8954 into vllm-project:main Oct 21, 2024
70 checks passed
This was referenced Oct 22, 2024
Closed
Merged
charlifu pushed a commit to charlifu/vllm that referenced this pull request Oct 23, 2024
@yudian0504 @charlifu
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
48bc888 
Signed-off-by: charlifu <charlifu@amd.com>
vrdn-23 pushed a commit to vrdn-23/vllm that referenced this pull request Oct 23, 2024
@yudian0504 @vrdn-23
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
df5d1f9 
Signed-off-by: Vinay Damodaran <vrdn@hey.com>
Alvant pushed a commit to compressa-ai/vllm that referenced this pull request Oct 26, 2024
@yudian0504 @Alvant
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
7fee2fa 
Signed-off-by: Alvant <alvasian@yandex.ru>
garg-amit pushed a commit to garg-amit/vllm that referenced this pull request Oct 28, 2024
@yudian0504 @garg-amit
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
7b256bc 
Signed-off-by: Amit Garg <mitgarg17495@gmail.com>
FerdinandZhong pushed a commit to FerdinandZhong/vllm that referenced this pull request Oct 29, 2024
@yudian0504 @FerdinandZhong
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
9892332 
Signed-off-by: qishuai <ferdinandzhong@gmail.com>
This was referenced Oct 29, 2024
Open
Closed
@xfalcox
Copy link

xfalcox commented Oct 31, 2024

This bug fix is so important, we need a release for the new docker image cc @DarkLight1337

@DarkLight1337
Copy link
Member

DarkLight1337 commented Oct 31, 2024 •
edited
Loading

This bug fix is so important, we need a release for the new docker image cc @DarkLight1337

For now, you can use the Docker image here with the latest commit.

This was referenced Nov 9, 2024
Closed
Closed
@RocketRider RocketRider mentioned this pull request Nov 10, 2024
Closed
1 task
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@yudian0504 @sumitd2
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
a414f3e 
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
ZenPuzzle pushed a commit to ZenPuzzle/vllm that referenced this pull request Nov 15, 2024
@yudian0504
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
9e02490
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
@yudian0504
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
c9a14d4
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
@yudian0504 @mfournioux
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
efc2ec2 
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@yudian0504 @tlrmchlsmth
[Bugfix][Misc]: fix graph capture for decoder (vllm-project#9549)
d4097b5 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@comaniac comaniac comaniac approved these changes

@varun-sundar-rabindranath varun-sundar-rabindranath varun-sundar-rabindranath approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yudian0504 @jeejeelee @xfalcox @DarkLight1337 @varun-sundar-rabindranath @comaniac