Linux daemon issue #2572
Merged
Linux daemon issue #2572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratkosrb
reviewed
Apr 6, 2024
imranh2
force-pushed
the
linux_daemon_issue
branch
from
2c4560b to
54cb3c6
Compare
|
Rebased changes / fixed merge conflict. |
imranh2
force-pushed
the
linux_daemon_issue
branch
from
54cb3c6 to
4f26d1a
Compare
imranh2
commented
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
In an attempt to fix the memory leak & process going nuts when launched in
daemonmode with the changes I made in #2527, simply don't launch the CLI when running in this mode. Rationale is that you can't even use the CLI easily if launched like this.There's also a change around paths and what your relative path is in
daemonmode, making it more consistent with non daemon mode.Also a small memory leak fix for the linux mangosd CLI.
Proof
Issues
How2Test
Todo / Checklist