Rewrite Golemagg and fix 'Golemagg's Trust' #2835
Merged
+319
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratkosrb
reviewed
Nov 17, 2024
|
|
||
| -- Moss Covered Feet - add SPELL_ATTR_EX_AURA_UNIQUE | ||
| INSERT INTO `spell_mod` (`Id`, `procChance`, `procFlags`, `procCharges`, `DurationIndex`, `Category`, `CastingTimeIndex`, `StackAmount`, `SpellIconID`, `activeIconID`, `manaCost`, `Attributes`, `AttributesEx`, `AttributesEx2`, `AttributesEx3`, `AttributesEx4`, `Custom`, `InterruptFlags`, `AuraInterruptFlags`, `ChannelInterruptFlags`, `Dispel`, `Stances`, `StancesNot`, `SpellVisual`, `ManaCostPercentage`, `StartRecoveryCategory`, `StartRecoveryTime`, `MaxAffectedTargets`, `MaxTargetLevel`, `DmgClass`, `rangeIndex`, `RecoveryTime`, `CategoryRecoveryTime`, `SpellFamilyName`, `SpellFamilyFlags`, `Mechanic`, `EquippedItemClass`, `Comment`) VALUES | ||
| (6870, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, 67110928, -1, -1, -1, 1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, -1, 0, -1, -1, 'Moss Covered Feet - Add unique aura flag'); |
There was a problem hiding this comment.
Without this modification, the spell can be applied multiple times to a player. I have no proof that this is correct - I just remember it not being applied more than once. I can remove this line if that’s preferable.
There was a problem hiding this comment.
#1223 (comment) - maybe this can be achieved differently, but currently I don't have any other idea except adding the unique flag.
ratkosrb
reviewed
Nov 17, 2024
src/game/Spells/SpellAuras.cpp
Outdated
| if (Unit* caster = GetCaster()) | ||
| { | ||
| // Azuregos | ||
| // Only cast Mark of Frost on targets nearby when engaged |
There was a problem hiding this comment.
I also have no poof for this - needs to be confirmed.
0blu
added
CPP
schell244
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Some fixes I've made for the RaspyWoW project.
Update: removed unverified changes.
Implemented missing handling for spells:
Moss Covered FeetBethor's PotionFixed implementation of spell:Mark of FrostScript of Golemagg is fully rewritten, with Golemagg's Trust now being implemented and also added the missing leash handling for his adds.
30 yards buff reach: wowhead
100 yards leash distance: Azerothcore
Proof
How2Test
Todo / Checklist