Some more code cleanup and refactoring #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ratkosrb
reviewed
Dec 7, 2024
src/game/World.h
Outdated
| public: | ||
| SessionPacketSendTask(const SessionPacketSendTask&) = delete; |
ratkosrb
reviewed
Dec 7, 2024
| @@ -491,7 +491,7 @@ void DungeonResetScheduler::ScheduleAllDungeonResets() | |||
| } | |||
| } | |||
|
|
|||
| void DungeonResetScheduler::ScheduleReset(bool add, time_t time, DungeonResetEvent event) | |||
| void DungeonResetScheduler::ScheduleReset(bool add, time_t const time, DungeonResetEvent event) | |||
There was a problem hiding this comment.
this is not a pointer so no need for the time parameter to be const
ratkosrb
reviewed
Dec 7, 2024
| @@ -300,7 +300,7 @@ class DungeonResetScheduler | |||
| m_resetTimeByMapId[mapId] = t; | |||
| } | |||
|
|
|||
| void ScheduleReset(bool add, time_t time, DungeonResetEvent event); | |||
| void ScheduleReset(bool add, time_t const time, DungeonResetEvent event); | |||
There was a problem hiding this comment.
no need for time to be const
ratkosrb
reviewed
Dec 7, 2024
| @@ -215,7 +215,7 @@ Creature::Creature(CreatureSubtype subtype) : | |||
|
|
|||
| Creature::~Creature() | |||
| { | |||
| CleanupsBeforeDelete(); | |||
| Unit::CleanupsBeforeDelete(); | |||
There was a problem hiding this comment.
why explicitly calling unit version
There was a problem hiding this comment.
Just for readability - there's no specific implementation for CleanupsBeforeDelete at creature (while at player there is, which then also calls Unit::CleanupsBeforeDelete).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Code cleanup and some fixes based on Clang-Tidy suggestions.
Also resolved some compiler warnings.
No behavioural changes.
Proof
Issues
How2Test
Todo / Checklist