Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd level lists become 2nd level ul lists. #254

Open
postmodern opened this issue May 29, 2013 · 14 comments
Open

3rd level lists become 2nd level ul lists. #254

postmodern opened this issue May 29, 2013 · 14 comments
Labels

Comments

@postmodern
Copy link

I noticed that 3rd level nested lists are emitted as 2nd level <ul> lists.

Tested on RedCarpet 2.2.2 and 2.3.0. Kramdown correctly nests 3rd nested level lists.

redcarpet ChangeLog.md > ChangeLog.redcarpet.html
firefox ChangeLog.redcarpet.html
kramdown -i markdown -o html <ChangeLog.md >ChangeLog.kramdown.html
firefox ChangeLog.kramdown.html
@aprescott
Copy link

See #115 where @vmg commented about a year ago on this, although things may have changed.

@robin850
Copy link
Collaborator

I think that this is not itended because 3rd level lists should be 3rd level lists ; lists should be considered as third level ones starting from the 4th level, no? However, if it is the expected behaviour, I personally think that 2 is not enough and we should also add an option to allow the user to choose its own maximum nesting level.

@aprescott
Copy link

From #115, looks like max_nesting is a C-related thing to achieve that, although obviously Ruby bindings would be another thing. (I might be talking nonsense...)

@postmodern
Copy link
Author

max_nesting is not an appropriate solution, since GitHub sets that value.

@aprescott
Copy link

Are you trying to fix a GitHub markdown issue by getting it fixed in Redcarpet? GitHub doesn't use Redcarpet, unless you mean something else.

@aprescott
Copy link

(I also didn't mean that max_nesting would be a fix for you as a user, by the way, I just wanted to throw it in as a pointer in case anyone else was going to fix it. I think 2-3 levels is probably not enough for a lot of people, and is a bit unsatisfactory.)

@postmodern
Copy link
Author

Last I heard, GitHub was still using RedCarpet. 2-3 levels is extremely low, also I question the reasoning behind not allowing arbitrary nesting. To my knowledge, no other markdown parser has had issues with arbitrarily nested lists.

@mattr-
Copy link
Collaborator

mattr- commented May 30, 2013

GitHub is no longer using Redcarpet. They're using something different now
that is derived from Redcarpet's code.

On Wed, May 29, 2013 at 7:16 PM, Postmodern notifications@git.luolix.topwrote:

Last I heard, GitHub was using RedCarpethttps://github.com/blog/832-rolling-out-the-redcarpet.
2-3 levels is extremely low, also I question the reasoning behind not
allowing arbitrary nesting. To my knowledge, no other markdown parser has
had issues with arbitrarily nested lists.


Reply to this email directly or view it on GitHubhttps://github.com//issues/254#issuecomment-18654425
.

@postmodern
Copy link
Author

@mattr- Ah. Still, they are using RedCarpet's code-base. Not sure if they pull in upstream patches from RedCarpet.

@stefanozanella
Copy link

I might be missing something, but I was able to get a 3rd level nesting by adding an additional tab on 3rd level content. See here:
https://github.com/derecom/openwrt_builder/blob/master/README.md
https://raw.github.com/derecom/openwrt_builder/master/README.md

@gilbert
Copy link

gilbert commented Sep 24, 2013

Any updates on this? I'm also running into this issue.

@olivierlacan
Copy link

Ran into this issue on olivierlacan/keep-a-changelog#38

@robin850 I'd love to help on this.

@olivierlacan
Copy link

Interestingly GitHub's Markdown parser deals with nested lists properly.

image

@vmg any time to share? 😄

@aprescott
Copy link

@olivierlacan GitHub hasn't used Redcarpet in production for a long time. See #212.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants