Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gopkg.in canonical to avoid downstream replace directives #269

Closed
wants to merge 1 commit into from
Closed

make gopkg.in canonical to avoid downstream replace directives #269

wants to merge 1 commit into from

Conversation

lizthegrey
Copy link

Addresses problem with workaround for #266

@vmihailenco
Copy link
Owner

Go modules are available since Go 1.11 and now we are almost on Go 1.15. I think Go modules requirement is reasonable and people without Go modules should look for workarounds, not the other way round.

I am happy to improve Go modules support - not to replace Go module with something else. It is hard to predict what problem this change will cause for existing v4 users.

@lizthegrey
Copy link
Author

Same problem with russross/blackfriday#491 :(

@lizthegrey
Copy link
Author

Go modules are available since Go 1.11 and now we are almost on Go 1.15. I think Go modules requirement is reasonable and people without Go modules should look for workarounds, not the other way round.

I am happy to improve Go modules support - not to replace Go module with something else. It is hard to predict what problem this change will cause for existing v4 users.

This still uses Go modules, just changes the default import path so that Go module users & non-module users can all use the same path. But I can understand the reluctance to change the import path.

(ironically, the problem is that using gopkg.in paths with go1.12 modules fails without this)

@vmihailenco
Copy link
Owner

Closing since v5 is stable for some time now.

@vmihailenco vmihailenco closed this Feb 3, 2021
@lizthegrey lizthegrey deleted the lizf.import-paths branch February 3, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants