Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Register GCP auth provider #105

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

unguiculus
Copy link
Contributor

Fixes: #94
Signed-off-by: Reinhard Nägele unguiculus@gmail.com

Signed-off-by: Reinhard Nägele <unguiculus@gmail.com>
@vmwclabot
Copy link

@unguiculus, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link

@unguiculus, VMware has approved your signed contributor license agreement.

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2021

Codecov Report

Merging #105 (0c5bdf8) into main (3e821b5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   65.27%   65.30%   +0.03%     
==========================================
  Files          40       40              
  Lines        2825     2825              
==========================================
+ Hits         1844     1845       +1     
+ Misses        759      758       -1     
  Partials      222      222              
Flag Coverage Δ
integration-tests 62.13% <ø> (+0.03%) ⬆️
unit-tests 9.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/driver/kubernetes/factory.go 70.19% <ø> (ø)
pkg/driver/kubernetes/creation.go 67.24% <0.00%> (+0.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e821b5...0c5bdf8. Read the comment docs.

@dhiltgen
Copy link
Contributor

dhiltgen commented Oct 8, 2021

Thanks for fixing this one!

@dhiltgen dhiltgen merged commit 1952a54 into vmware-archive:main Oct 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed due to 'no Auth Provider found for name "gcp"'
4 participants