Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

feat: use -trimpath and buildid= for better reproducible binaries #126

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

developer-guy
Copy link
Contributor

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com
Co-authored-by: Furkan Türkal furkan.turkal@trendyol.com
cc: @Dentrax

@vmwclabot
Copy link

@developer-guy, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
Co-authored-by: Furkan Türkal <furkan.turkal@trendyol.com>
Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy
Copy link
Contributor Author

kindly ping 🙋🏻‍♂️

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #126 (68ed1b5) into main (cbe62af) will increase coverage by 6.26%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   58.97%   65.23%   +6.26%     
==========================================
  Files          40       40              
  Lines        2825     2825              
==========================================
+ Hits         1666     1843     +177     
+ Misses        946      759     -187     
- Partials      213      223      +10     
Flag Coverage Δ
integration-tests 62.06% <ø> (+6.28%) ⬆️
unit-tests 9.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/driver/kubernetes/driver.go 66.29% <0.00%> (+2.20%) ⬆️
pkg/driver/kubernetes/factory.go 70.19% <0.00%> (+2.64%) ⬆️
pkg/build/build.go 48.26% <0.00%> (+8.92%) ⬆️
pkg/driver/kubernetes/creation.go 66.09% <0.00%> (+11.49%) ⬆️
pkg/driver/kubernetes/manifest/manifest.go 96.53% <0.00%> (+38.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbe62af...68ed1b5. Read the comment docs.

@dhiltgen
Copy link
Contributor

dhiltgen commented Mar 2, 2022

Sorry for the delay. Thanks for the PR!

@dhiltgen dhiltgen merged commit ba85acc into vmware-archive:main Mar 2, 2022
@vmwclabot
Copy link

@developer-guy, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

@vmwclabot
Copy link

@developer-guy, your company's legal contact did not review your signed contributor license agreement within the 14 day limit. The merge can not proceed. Click here to resign the agreement.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants