Skip to content
This repository has been archived by the owner on Mar 27, 2023. It is now read-only.

[NG] update dependency ng-packagr to ^1.5.0 #1608

Merged
merged 1 commit into from
Nov 7, 2017

Conversation

dherges
Copy link
Contributor

@dherges dherges commented Oct 18, 2017

@vmwclabot
Copy link

@dherges, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@dherges dherges changed the title chore: update dependency ng-packagr to 1.5.0-rc.0 chore: update dependency ng-packagr to 1.5.0-rc.1 Oct 23, 2017
@dherges dherges changed the title chore: update dependency ng-packagr to 1.5.0-rc.1 [NG] update dependency ng-packagr to 1.5.0-rc.1 Oct 23, 2017
@gnomeontherun
Copy link
Contributor

Hey @dherges we do not currently plan to split the Angular library into separate packages, though should that become an Angular recommendation then we'd certainly consider it. We also don't really expose any testing stubs, but if we ddi that might be an ideal use case. If your application can properly tree shake, there is less incentive IMO to make the consumption model of the library more complex through many packages. For the time being, our components are not truly isolated because they depend on clarity-ui to get much of their styling. We'll take a closer look at this version bump, and do you have any other expected changes (excluding bugfixes) before the next release?

We do need you to fix up your PR by adding a sign-off to your commit message for CLA compliance, if you don't mind!

@dherges
Copy link
Contributor Author

dherges commented Oct 26, 2017

From 1.4.1 to 1.5.x:

https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#150-rc1-2017-10-23

Something I am thinking about and would appreciate your team's ideas about it, is whether the minimalistic configuration should be stored in package.json (and then maybe deprecate ng-package.json), see ng-packagr/ng-packagr#190.

@gnomeontherun
Copy link
Contributor

It looks fine to me, just asking for a quick sanity check from @hippee-lee or @jeeyun

@adibwoy
Copy link
Contributor

adibwoy commented Nov 3, 2017

@jeeyun could you please review this?

@vmwclabot
Copy link

@dherges, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding Signed-off-by: John Doe <john.doe@email.org> to the last line of each Git commit message. The e-mail address used to sign must match the e-mail address of the Git author. Click here to view the Developer Certificate of Origin agreement.

@dherges
Copy link
Contributor Author

dherges commented Nov 5, 2017

Hi all, I published ng-packagr@1.5.0. It seems to work with Angular 5, here is a demo repo for ng-packagr and Angular 5

The changelog for the collected changes from 1.4.1 to 1.5.0

@dherges dherges changed the title [NG] update dependency ng-packagr to 1.5.0-rc.1 [NG] update dependency ng-packagr to ^1.5.0 Nov 5, 2017
Signed-Off-By: David Herges <dherges@users.noreply.github.com>
@gnomeontherun gnomeontherun merged commit 43855cd into vmware-archive:master Nov 7, 2017
@dherges dherges deleted the patch-1 branch November 8, 2017 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants