-
Notifications
You must be signed in to change notification settings - Fork 762
[NG] update dependency ng-packagr to ^1.5.0 #1608
Conversation
@dherges, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Hey @dherges we do not currently plan to split the Angular library into separate packages, though should that become an Angular recommendation then we'd certainly consider it. We also don't really expose any testing stubs, but if we ddi that might be an ideal use case. If your application can properly tree shake, there is less incentive IMO to make the consumption model of the library more complex through many packages. For the time being, our components are not truly isolated because they depend on clarity-ui to get much of their styling. We'll take a closer look at this version bump, and do you have any other expected changes (excluding bugfixes) before the next release? We do need you to fix up your PR by adding a sign-off to your commit message for CLA compliance, if you don't mind! |
From 1.4.1 to 1.5.x:
https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#150-rc1-2017-10-23 Something I am thinking about and would appreciate your team's ideas about it, is whether the minimalistic configuration should be stored in |
It looks fine to me, just asking for a quick sanity check from @hippee-lee or @jeeyun |
@jeeyun could you please review this? |
@dherges, you must sign every commit in this pull request acknowledging our Developer Certificate of Origin before your changes are merged. This can be done by adding
|
Hi all, I published ng-packagr@1.5.0. It seems to work with Angular 5, here is a demo repo for ng-packagr and Angular 5 The changelog for the collected changes from 1.4.1 to 1.5.0 |
Signed-Off-By: David Herges <dherges@users.noreply.github.com>
New flagship feature of ng-packagr are secondary entrypoints
Do you plan to follow the Angular Material style of splitting up the library into sub-packages?