This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
fix(website): no longer depend on the legacy custom-elements json file #6309
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Website no longer depends on the
custom-elements.legacy.json
file that we generate.At the moment the legacy file is used for generating control knobs for the Storybook.
To fully remove the dependency and the need of generating the legacy file we need to wait for a new package for
@web/storybook-prebuild
Right now the
@web/storybook-prebuilt@0.1.25
that is the latest stable release is not compatible with the new custom elements format. It comes with prebuild Storybook 6.3.7~ - we require 6.4.0~ -The alpha version of
@web/storybook-prebuilt@0.1.26.alpha.1
comes with6.4.0-alpha.33
. But because isalpha
(unstable) release I prefer to wait a little longer before updating the packages. The estimated release for stable 6.4.0 is (2021-09-20) so I suspect by the end of September we could update the Storybook prebuild package.The update of the Storybook will resolve these issues:
custom-elements.legacy.json
fileStorybook 6.4.0 Release notes