This repository has been archived by the owner on Nov 17, 2021. It is now read-only.
Update to Kubernetes 1.19, remove k8s.io/kubernetes dependency, unpin gnostic #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
|
Ah! Looks like I didn't try the integration tests. Let me fix that up real quick. |
|
@q3k any chance you can resurrect this, I'd really love to merge it |
|
@mkmik Sure, let me take a stab at this again. |
q3k
force-pushed
the
q3k/update-kube-1.19
branch
from
5070ed2
to
af3cae9
Compare
The last package to come from k8s.io/kubernetes was kubectl/cmd/util/openapi, which has since been moved to k8s.io/util. We update to Kubernetes 1.19, remove the direct dependency on k8s.io/kubernetes (now only using client code from other k8s.io repos), and unpin gnostic to the newest version.
q3k
force-pushed
the
q3k/update-kube-1.19
branch
from
af3cae9
to
6a687a1
Compare
|
@mkmik Friendly ping, is there something blocking this merge again? :) |
|
@q3k no sorry, I just didn't see any notification about your pushes last month :-( |
mkmik
approved these changes
Mar 9, 2021
mkmik
reviewed
May 5, 2021
| github.com/google/gofuzz v1.1.0 // indirect | ||
| github.com/googleapis/gnostic v0.4.0 | ||
| github.com/golang/protobuf v1.4.3 | ||
| github.com/google/go-jsonnet v0.15.0 |
There was a problem hiding this comment.
just noticed that this reverted go-jsonnet back to 0.15 after we released kubecfg 0.17.0 which had go-jsonnet 0.17.0
🤦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up multiple small things around kubecfg's build/dependencies.
First, we remove the dependency on k8s.io/kubernetes, which is not supported by the Kubernetes developers. We re-pin all client k8s.io/* libraries to Kubernetes 1.19.3.
We remove the github.com/googleapis/gnostic 0.4.0 rename as the issue has since been fixed upstream.
We then fix the command code to pass contexts to Kubernetes client calls that now require a context.
Finally, we update the vendor directory.