Use camelcase for javascript plugin state

Signed-off-by: vikram yadav <vyadav@pivotal.io>
vmware-archive · Apr 1, 2021 · f123c1d · f123c1d
1 parent c80b24b
commit f123c1d
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/changelogs/unreleased/2244-xtreme-vikram-yadav b/changelogs/unreleased/2244-xtreme-vikram-yadav
@@ -0,0 +1 @@
+Share partial octant state with plugins
diff --git a/pkg/action/actions.go b/pkg/action/actions.go
@@ -11,7 +11,7 @@ const (
 	// of the new current namespace.
 	RequestSetNamespace = "action.octant.dev/setNamespace"
 
-	// RequestSteFilter is the action for when the filters are updated in Octant.
+	// RequestSetFilter is the action for when the filters are updated in Octant.
 	// The ActionRequest.Payload for this action contains an array of key/values representing
 	// the filters.
 	RequestSetFilter = "action.octant.dev/setFilter"

diff --git a/pkg/plugin/dashboard/dashboard.pb.go b/pkg/plugin/dashboard/dashboard.pb.go
diff --git a/pkg/plugin/javascript.go b/pkg/plugin/javascript.go
@@ -238,7 +238,7 @@ func (t *jsPlugin) Content(ctx context.Context, contentPath string) (component.C
 
 	t.loop.RunOnLoop(func(vm *goja.Runtime) {
 		clientID := ocontext.WebsocketClientIDFrom(ctx)
-		ostate := ocontext.PluginStateFrom(ctx)
+		oState := ocontext.PluginStateFrom(ctx)
 
 		handler, err := vm.RunString("_concretePlugin.contentHandler")
 		if err != nil {
@@ -259,7 +259,7 @@ func (t *jsPlugin) Content(ctx context.Context, contentPath string) (component.C
 		if err := obj.Set("clientID", vm.ToValue(clientID)); err != nil {
 			errCh <- fmt.Errorf("unable to set clientID: %w", err)
 		}
-		if err := obj.Set("ostate", vm.ToValue(ostate)); err != nil {
+		if err := obj.Set("oState", vm.ToValue(oState)); err != nil {
 			errCh <- fmt.Errorf("unable to set octant state: %w", err)
 		}
 
@@ -462,7 +462,7 @@ func (t *jsPlugin) HandleAction(ctx context.Context, actionPath string, payload
 
 	t.loop.RunOnLoop(func(vm *goja.Runtime) {
 		clientID := ocontext.WebsocketClientIDFrom(ctx)
-		ostate := ocontext.PluginStateFrom(ctx)
+		oState := ocontext.PluginStateFrom(ctx)
 
 		handler, err := vm.RunString("_concretePlugin.actionHandler")
 		if err != nil {
@@ -492,7 +492,7 @@ func (t *jsPlugin) HandleAction(ctx context.Context, actionPath string, payload
 			errCh <- fmt.Errorf("unable to set clientID: %w", err)
 			return
 		}
-		if err := obj.Set("ostate", vm.ToValue(ostate)); err != nil {
+		if err := obj.Set("oState", vm.ToValue(oState)); err != nil {
 			errCh <- fmt.Errorf("unable to set octant state: %w", err)
 		}
 
@@ -579,7 +579,7 @@ func (t *jsPlugin) objectRequestCall(ctx context.Context, handlerName string, ob
 
 	t.loop.RunOnLoop(func(vm *goja.Runtime) {
 		clientID := ocontext.WebsocketClientIDFrom(ctx)
-		ostate := ocontext.PluginStateFrom(ctx)
+		oState := ocontext.PluginStateFrom(ctx)
 
 		handler, err := vm.RunString(fmt.Sprintf("_concretePlugin.%s", handlerName))
 		if err != nil {
@@ -602,7 +602,7 @@ func (t *jsPlugin) objectRequestCall(ctx context.Context, handlerName string, ob
 			errCh <- fmt.Errorf("unable to set clientID: %w", err)
 			return
 		}
-		if err := obj.Set("ostate", vm.ToValue(ostate)); err != nil {
+		if err := obj.Set("oState", vm.ToValue(oState)); err != nil {
 			errCh <- fmt.Errorf("unable to set octant state: %w", err)
 		}
 		s, err := cHandler(t.pluginClass, obj)