This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com> Co-authored-by: Nana Asiedu-Ampem <nasieduampem@vmware.com>
wwitzel3
force-pushed
the
issue-1102
branch
2 times, most recently
from
July 30, 2020 13:37
d9a7f5f
to
ab1338b
Compare
@GuessWhoSamFoo or @mklanjsek can either of you take a look at this and see if you can figure out what is causing the property error? |
Started looking at this right now |
Thanks @mklanjsek , the error I am seeing is in the issue, #1102 (comment) I only see it the first time I attempt to load the component in the Cnavas, this error does not occur when it first loads in to the docs. |
I'll rebase after review. |
mklanjsek
suggested changes
Aug 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One small thing in regards to component updates
web/src/app/modules/shared/components/presentation/stepper/stepper.component.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com> Co-authored-by: Nana Asiedu-Ampem <nasieduampem@vmware.com>
@mklanjsek PTAL |
mklanjsek
approved these changes
Aug 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Witzel III wayne@riotousliving.com