Skip to content
This repository has been archived by the owner on Jan 19, 2023. It is now read-only.

Add stepper component. #1177

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Add stepper component. #1177

merged 2 commits into from
Aug 5, 2020

Conversation

wwitzel3
Copy link
Contributor

@wwitzel3 wwitzel3 commented Jul 29, 2020

Signed-off-by: Wayne Witzel III wayne@riotousliving.com

image

image

Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Co-authored-by: Nana Asiedu-Ampem <nasieduampem@vmware.com>
@wwitzel3 wwitzel3 force-pushed the issue-1102 branch 2 times, most recently from d9a7f5f to ab1338b Compare July 30, 2020 13:37
@wwitzel3
Copy link
Contributor Author

wwitzel3 commented Aug 3, 2020

@GuessWhoSamFoo or @mklanjsek can either of you take a look at this and see if you can figure out what is causing the property error?

@mklanjsek
Copy link
Contributor

Started looking at this right now

@wwitzel3
Copy link
Contributor Author

wwitzel3 commented Aug 3, 2020

Thanks @mklanjsek , the error I am seeing is in the issue, #1102 (comment)

I only see it the first time I attempt to load the component in the Cnavas, this error does not occur when it first loads in to the docs.

@wwitzel3 wwitzel3 marked this pull request as ready for review August 3, 2020 17:18
@wwitzel3
Copy link
Contributor Author

wwitzel3 commented Aug 3, 2020

I'll rebase after review.

Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One small thing in regards to component updates

Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Co-authored-by: Nana Asiedu-Ampem <nasieduampem@vmware.com>
@wwitzel3
Copy link
Contributor Author

wwitzel3 commented Aug 4, 2020

@mklanjsek PTAL

Copy link
Contributor

@mklanjsek mklanjsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, LGTM.

@wwitzel3 wwitzel3 merged commit ad9c242 into vmware-archive:master Aug 5, 2020
@wwitzel3 wwitzel3 deleted the issue-1102 branch March 13, 2021 15:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants