This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
errors - explictly check for AccessErrors for CRDs and Events #2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested it some more and it isn't quite ready yet. |
wwitzel3
force-pushed
the
error-handling
branch
2 times, most recently
from
571d4e4
to
1106e15
Compare
wwitzel3
force-pushed
the
error-handling
branch
3 times, most recently
from
bc8c2d2
to
3f71d07
Compare
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
wwitzel3
force-pushed
the
error-handling
branch
3 times, most recently
from
fa740d5
to
7ea9e61
Compare
Signed-off-by: Wayne Witzel III <wayne@riotousliving.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wayne Witzel III wayne@riotousliving.com
What this PR does / why we need it:
Octant is currently broken with respect to partial resource loading on overview and summary pages.
Currently when attempting to load overview and summary pages if any single item in the listing fails, the entire content response is replaced with an error page. In the case of Overview pages, an emptyContentResponse is used and the page is stuck with the loading icon, even though some of the state was able to be fetched.
Special notes for your reviewer:
This fix is not ideal and a bit of shotgun anti-pattern, but it also unbreaks a lot of users in the short term and it important for restoring the functionality of Octant