This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Small improvements to Stock Ticker service #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jooskim
force-pushed
the
topic/kjosh/stock-ticker-sample-svc
branch
from
26eaa58 to
5fcdafc
Compare
This PR exposes a REST endpoint for the Stock Ticker service so REST clients could query the service for the latest price for a symbol. Unlike with the WebSocket version only one response will be generated for the request. Also as a minor improvement to the experience, now a request made either through REST or WebSocket will be responded immediately instead of after 30 seconds have passed. Signed-off-by: Josh Kim <kjosh@vmware.com>
jooskim
force-pushed
the
topic/kjosh/stock-ticker-sample-svc
branch
from
5fcdafc to
c6a6d29
Compare
daveshanley
reviewed
Aug 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes a REST endpoint for the Stock Ticker service so REST
clients could query the service for the latest price for a symbol.
Unlike with the WebSocket version only one response will be generated
for the request. Also as a minor improvement to the experience, now
a request made either through REST or WebSocket will be responded
immediately instead of after 30 seconds have passed.
Signed-off-by: Josh Kim kjosh@vmware.com