Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore: Consolidate go.mod into one file #30

Merged
merged 2 commits into from
Sep 13, 2021

Conversation

jooskim
Copy link
Collaborator

@jooskim jooskim commented Sep 13, 2021

go.mod being split between main Transport library and Plank does not really add to anything useful, in fact it introduces unexpected behaviors as Plank's dependency to Transport is loosely defined. By consolidating the separate go.mod files we make the effort of versioning and maintaining Transport components and their dependencies much easier.

Signed-off-by: Josh Kim kjosh@vmware.com

Signed-off-by: Josh Kim <kjosh@vmware.com>
@jooskim jooskim force-pushed the topic/kjosh/consolidate-go-mod branch from b8008e9 to b6377f1 Compare September 13, 2021 18:59
@codecov-commenter
Copy link

Codecov Report

Merging #30 (b6377f1) into main (d6393a4) will decrease coverage by 15.83%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #30       +/-   ##
===========================================
- Coverage   97.35%   81.52%   -15.84%     
===========================================
  Files          29       45       +16     
  Lines        1816     2419      +603     
===========================================
+ Hits         1768     1972      +204     
- Misses         48      447      +399     
Flag Coverage Δ
unittests 81.52% <0.00%> (-15.84%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
plank/pkg/server/server.go 28.49% <0.00%> (ø)
plank/utils/bytes.go 0.00% <0.00%> (ø)
plank/pkg/server/banner.go 52.27% <0.00%> (ø)
plank/utils/array.go 0.00% <0.00%> (ø)
plank/utils/runtime.go 88.88% <0.00%> (ø)
plank/utils/paths.go 0.00% <0.00%> (ø)
plank/pkg/server/neutered_fs.go 0.00% <0.00%> (ø)
plank/pkg/server/spa_config.go 0.00% <0.00%> (ø)
plank/utils/logger.go 21.27% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfdf4f8...b6377f1. Read the comment docs.

Copy link
Collaborator

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plank needs some test coverage bumps, it's dropped us 15% on coverage :)

Signed-off-by: Josh Kim <kjosh@vmware.com>
@jooskim jooskim merged commit 8ce7006 into vmware-archive:main Sep 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants