Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

Fix role_tests.py system test #486

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

andrew-ni
Copy link
Contributor

@andrew-ni andrew-ni commented Aug 22, 2019

@pandeys is there a ctot pipeline available to easily test this? or is there only manual testing?


This change is Reviewable

Signed-off-by: Andrew Ni <niandrew7@gmail.com>
@andrew-ni andrew-ni requested a review from pandeys August 22, 2019 19:10
Copy link

@pandeys pandeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @andrew-ni and @pandeys)


system_tests/role_tests.py, line 27 at r1 (raw file):

            self._config['vcd']['host'],
            self._config['vcd']['default_org_name'],
            Environment.get_username_for_role_in_test_org(CommonRoles.ORGANIZATION_ADMINISTRATOR),  # noqa: E501

Length is more than 80 characters.

Copy link

@pandeys pandeys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @andrew-ni)

Signed-off-by: Andrew Ni <niandrew7@gmail.com>
Copy link
Contributor Author

@andrew-ni andrew-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pandeys)


system_tests/role_tests.py, line 27 at r1 (raw file):

Previously, pandeys (SAURABH PANDEY) wrote…

Length is more than 80 characters.

the # noqa: E501 at the end makes this line an exception to rule E501, the line length rule, but i'll change it to conform

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants