This repository has been archived by the owner on Mar 27, 2023. It is now read-only.
Generate V1 CRDs #56
Merged
Generate V1 CRDs #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update tools to newer versions. Note that despite preserveUnknownFields, this is not included in the generated CRDs due to [1]. Importing our local kustomize hack to include it here does not seem worthwhile since it is mostly an upgrade issue. [1] - kubernetes-sigs/controller-tools#476
janitha
approved these changes
Jan 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update tools to newer versions.
Note that despite preserveUnknownFields, this is not included in the
generated CRDs due to [1]. Importing our local kustomize hack to
include it here does not seem worthwhile since it is mostly an upgrade
issue.
[1] - kubernetes-sigs/controller-tools#476