-
Notifications
You must be signed in to change notification settings - Fork 44
Secure etcd deployment with TLS assets generated by kubeadm #112
Conversation
@alexbrand Can you have a look at this PR and see if you can resolve any merge conflicts? |
@chuckha ptal |
Created a secure-etcd role which uses kubeadm to generate all TLS assets required to bootstrap a secure etcd cluster. Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
7126771
to
e6f3727
Compare
@scottslowe all set 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one tiny nit since I don't know much about Ansible's syntax.
from a kubeadm perspective this looks 💯! Super excited to have this change in wardroom. I think this unblocks standing up a multi-node control plane cluster with the Quickstart.
ansible/roles/etcd/tasks/main.yml
Outdated
- ca.crt | ||
- ca.key | ||
register: etcd_ca_pki | ||
delegate_to: "{{ groups['etcd'][0] }}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the [0]
in a few places here and |first
later on, should these be consistent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call. I've updated to |first
Signed-off-by: Alexander Brand <alexbrand09@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Closing as this is superseded by #181 |
Fixes #40
The following PR deploys a secure etcd cluster (listening on HTTPS for clients and peers).
The etcd role now:
The kubernetes-masters role now:
Notes for reviewer: