Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Update dependencies #115

Merged
merged 1 commit into from
Nov 28, 2018
Merged

Update dependencies #115

merged 1 commit into from
Nov 28, 2018

Conversation

chuckha
Copy link
Contributor

@chuckha chuckha commented Nov 26, 2018

dig was not included but is now required by aws-quickstart.

Signed-off-by: Chuck Ha ha.chuck@gmail.com

dig was not included but is now required by aws-quickstart.

Signed-off-by: Chuck Ha <ha.chuck@gmail.com>
@timothysc
Copy link
Contributor

/assign @detiber

@craigtracey
Copy link
Contributor

Out of curiosity, what is the requirement here for dig? Ideally we are only installing packages that are necessary for kubernetes as extraneous packages may not be necessary for other use cases.

@chuckha
Copy link
Contributor Author

chuckha commented Nov 26, 2018

I was surprised at this too, it got added to aws-quickstart a few months back. might be that the real fix would be to remove dig from wardroom and use some other method to retrieve the LB IP.
I'm hoping this bit of tech debt will be ok. I'm happy to track the work with a ticket for removal during the next iteration of aws-quickstart. https://github.com/heptio/aws-quickstart/blob/master/scripts/setup-k8s-master.sh.in#L49

@chuckha
Copy link
Contributor Author

chuckha commented Nov 26, 2018

Copy link
Contributor

@detiber detiber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@craigtracey craigtracey merged commit a234efc into vmware-archive:master Nov 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants