Support kubelet environment file #142
Conversation
With 1.11 the kubelet packages now support an external kubelet
environment file. Update the placement of this configuration from the
kubelet.d directory to the /etc/{default|sysconfig}/kubelet file.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
|
cc: @erictcgs |
|
Overall this LGTM. In the future, should we move to kubeadm's Ref: |
There was a problem hiding this comment.
No changes needed right now, but I do echo @alexbrand's question about moving these to the appropriate sections of a kubeadm configuration file.
|
We will also need to support other items that may/may not be included in KUBELET_EXTRA_ARGS. #143 Edit: Indeed, it looks like this use case is not covered by kubeadm: https://github.com/kubernetes/kubernetes/blob/master/cmd/kubeadm/app/apis/kubeadm/v1beta2/types.go#L195-L214 |
|
Got it. The env file gives us the ability to not only set KUBELET_EXTRA_ARGS, but also set other env vars on the kubelet process. |
Add the capability to add environment vars to the kubelet's systemd environment file. This will let folks add arbitrary env vars for things like $HOME, etc. Signed-off-by: Craig Tracey <craigtracey@gmail.com>
|
@scottslowe @alexbrand sorry about the false start here. Mind checking the latest commit to add the request from @erictcgs in #143. Adding this as a single PR will make it a bit easier to update tags / backport. |
* Support kubelet environment file
With 1.11 the kubelet packages now support an external kubelet
environment file. Update the placement of this configuration from the
kubelet.d directory to the /etc/{default|sysconfig}/kubelet file.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
* Support env vars in kubelet environment file
Add the capability to add environment vars to the kubelet's systemd
environment file. This will let folks add arbitrary env vars for things
like $HOME, etc.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
* Support kubelet environment file
With 1.11 the kubelet packages now support an external kubelet
environment file. Update the placement of this configuration from the
kubelet.d directory to the /etc/{default|sysconfig}/kubelet file.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
* Support env vars in kubelet environment file
Add the capability to add environment vars to the kubelet's systemd
environment file. This will let folks add arbitrary env vars for things
like $HOME, etc.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
* Support kubelet environment file
With 1.11 the kubelet packages now support an external kubelet
environment file. Update the placement of this configuration from the
kubelet.d directory to the /etc/{default|sysconfig}/kubelet file.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
* Support env vars in kubelet environment file
Add the capability to add environment vars to the kubelet's systemd
environment file. This will let folks add arbitrary env vars for things
like $HOME, etc.
Signed-off-by: Craig Tracey <craigtracey@gmail.com>
With 1.11 the kubelet packages now support an external kubelet
environment file. Update the placement of this configuration from the
kubelet.d directory to the /etc/{default|sysconfig}/kubelet file.
Will cherry pick this change into the future branches as well.
Signed-off-by: Craig Tracey craigtracey@gmail.com