This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 44
Add qemu builders and update README #49
Open
detiber
wants to merge
3
commits into
vmware-archive:master
Choose a base branch
from
detiber:qemu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Adds packer qemu builders - Adds Vagrant and vagrant cloud support for building and pushing Vagrant libvirt images - Adds additional packer cleanup - Adds a Vagrantfile for doing a test of node conformance against libvirt/ubuntu vagrant cloud box Signed-off-by: Jason DeTiberus <detiber@gmail.com>
craigtracey
suggested changes
Apr 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we prefer preseed/kickstart over a pre-baked image from upstream? I think leveraging upstream images would be much more reliable.
path: "{{ item }}" | ||
with_items: | ||
- "/home/{{ ansible_env.SUDO_USER }}/.ssh/authorized_keys" | ||
when: packer_builder_type | default(None) != 'qemu' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we want to preserve authorized_keys for qemu?
if builder_type.startswith('amazon'): | ||
return 'aws' | ||
elif builder_type == 'qemu': | ||
return 'vagrant' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on how we handle this when we want to support straight qemu?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds qemu builders for packer and updates the README accordingly.
Signed-off-by: Jason DeTiberus detiber@gmail.com