Skip to content
This repository has been archived by the owner on Mar 2, 2022. It is now read-only.

Add qemu builders and update README #49

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

detiber
Copy link
Contributor

@detiber detiber commented Mar 13, 2018

Adds qemu builders for packer and updates the README accordingly.

Signed-off-by: Jason DeTiberus detiber@gmail.com

@detiber detiber requested review from craigtracey and liztio March 13, 2018 20:27
- Adds packer qemu builders
- Adds Vagrant and vagrant cloud support for building and pushing
  Vagrant libvirt images
- Adds additional packer cleanup
- Adds a Vagrantfile for doing a test of node conformance against
  libvirt/ubuntu vagrant cloud box

Signed-off-by: Jason DeTiberus <detiber@gmail.com>
Copy link
Contributor

@craigtracey craigtracey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we prefer preseed/kickstart over a pre-baked image from upstream? I think leveraging upstream images would be much more reliable.

path: "{{ item }}"
with_items:
- "/home/{{ ansible_env.SUDO_USER }}/.ssh/authorized_keys"
when: packer_builder_type | default(None) != 'qemu'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason we want to preserve authorized_keys for qemu?

if builder_type.startswith('amazon'):
return 'aws'
elif builder_type == 'qemu':
return 'vagrant'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on how we handle this when we want to support straight qemu?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants