Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagrid column expands to 100% when details pane is opened #338

Closed
2 of 7 tasks
banchevskii opened this issue Oct 7, 2022 · 2 comments · Fixed by #339
Closed
2 of 7 tasks

Datagrid column expands to 100% when details pane is opened #338

banchevskii opened this issue Oct 7, 2022 · 2 comments · Fixed by #339
Assignees
Labels

Comments

@banchevskii
Copy link

Describe the bug

When the details pane of a datagrid is opened a width: 100% !important is being applied to the clr-dg-cell. This causes an issue when we have another datagrid inside the details pane - the same width is being applied there, which makes the first column expand to the width of the datagrid, pushing the rest of the columns outside of the view, making them invisible.

How to reproduce

Reproducable Stackblitz

Steps to reproduce the behavior:
Those steps apply to the Stackblitz example

  1. Resize the browser view so the full datagrid is visible
  2. Open the details pane of the first row
  3. Open the details pane on any other row
  4. Notice how the datagrid inside the details pane, only shows the first column as it is expanded to 100% width

Expected behavior

The datagrid's cell inside the details pane should not have a 100% width

Versions

Clarity version:

  • v12.x
  • v13.x
  • Other:

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
Angular 13

Device:
Latest chrome on a Macbook

Additional notes

Add any other notes about the problem here.

@kevinbuhmann kevinbuhmann self-assigned this Oct 7, 2022
kevinbuhmann added a commit that referenced this issue Oct 7, 2022
The open detail panel styles should only be applied to the datagrid that
owns the open detail panel, not to datagrids inside said detail panel.

closes #338
kevinbuhmann added a commit that referenced this issue Oct 7, 2022
The open detail panel styles should only be applied to the datagrid that
owns the open detail panel, not to datagrids inside said detail panel.

closes #338
kevinbuhmann added a commit that referenced this issue Oct 10, 2022
The open detail panel styles should only be applied to the datagrid that
owns the open detail panel, not to datagrids inside said detail panel.

closes #338
kevinbuhmann added a commit that referenced this issue Oct 10, 2022
The open detail panel styles should only be applied to the datagrid that
owns the open detail panel, not to datagrids inside said detail panel.

closes #338
kevinbuhmann added a commit that referenced this issue Oct 11, 2022
The open detail panel styles should only be applied to the datagrid that
owns the open detail panel, not to datagrids inside said detail panel.

closes #338
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 13.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
2 participants